Add Exposing Prometheus and Alertmanager link to Platform Guide#115
Open
SamarthJejurkar wants to merge 1 commit intoprometheus-operator:mainfrom
Open
Add Exposing Prometheus and Alertmanager link to Platform Guide#115SamarthJejurkar wants to merge 1 commit intoprometheus-operator:mainfrom
SamarthJejurkar wants to merge 1 commit intoprometheus-operator:mainfrom
Conversation
Contributor
|
Hey @SamarthJejurkar thanks for that, can you check CI? |
Comment on lines
+49
to
+54
| <div class="col-lg-5"> | ||
| <h2 class="h4">Exposing Prometheus and Alertmanager</h2> | ||
| <p>Learn how to expose Prometheus and Alertmanager services.</p> | ||
| <a href="/docs/platform-guides/exposing-prometheus-and-alertmanager/" class="btn btn-primary">Read More</a> | ||
| </div> | ||
|
|
Member
There was a problem hiding this comment.
There is no need to add this here. You are adding this div to the website's landing page.
| cp repos/prometheus-operator/Documentation/troubleshooting.md content/docs/platform/troubleshooting.md | ||
| cp repos/prometheus-operator/Documentation/user-guides/storage.md content/docs/platform/storage.md | ||
| cp repos/prometheus-operator/Documentation/user-guides/strategic-merge-patch.md content/docs/platform/strategic-merge-patch.md | ||
| cp repos/prometheus-operator/Documentation/user-guides/exposing-prometheus-and-alertmanager.md content/docs/platform-guides/exposing-prometheus-and-alertmanager.md |
Member
There was a problem hiding this comment.
Suggested change
| cp repos/prometheus-operator/Documentation/user-guides/exposing-prometheus-and-alertmanager.md content/docs/platform-guides/exposing-prometheus-and-alertmanager.md | |
| cp repos/prometheus-operator/Documentation/user-guides/exposing-prometheus-and-alertmanager.md content/docs/platform/exposing-prometheus-and-alertmanager.md |
Member
There was a problem hiding this comment.
Platform-guide is the name of the section in the website while platform is the name of the folder in the repo.
Member
AshwinSriram11
left a comment
AshwinSriram11
left a comment
There was a problem hiding this comment.
Good start. I have added some comments. Feel free to ask your doubts.
Member
|
You would also need to open a PR in the main repo where you add a header section to specify the position of the doc in the Platform-Guide section. It looks like this: You can find it on each markdown file that is included in the website. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.